[flang] Move FIRSupport dependency to correct place #125697
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library is provided by flang, not MLIR, so it should not be part of MLIR_LIBS.
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-fir-hlfir Author: Nikita Popov (nikic) ChangesThis library is provided by flang, not MLIR, so it should not be part of MLIR_LIBS. Fixes an issue introduced in #120966. Full diff: https://github.com/llvm/llvm-project/pull/125697.diff 1 Files Affected:
diff --git a/flang/lib/Optimizer/Analysis/CMakeLists.txt b/flang/lib/Optimizer/Analysis/CMakeLists.txt
index 6fe9c70f83765f..c4dae898f8e572 100644
--- a/flang/lib/Optimizer/Analysis/CMakeLists.txt
+++ b/flang/lib/Optimizer/Analysis/CMakeLists.txt
@@ -12,6 +12,7 @@ add_flang_library(FIRAnalysis
LINK_LIBS
FIRBuilder
FIRDialect
+ FIRSupport
HLFIRDialect
MLIR_LIBS
@@ -19,5 +20,4 @@ add_flang_library(FIRAnalysis
MLIRLLVMDialect
MLIRMathTransforms
MLIROpenMPDialect
- FIRSupport
)
|
mgorny
approved these changes
Feb 4, 2025
nikic
added a commit
to nikic/llvm-project
that referenced
this pull request
Feb 5, 2025
This library is provided by flang, not MLIR, so it should not be part of MLIR_LIBS. Fixes an issue introduced in llvm#120966. (cherry picked from commit ee76bda)
nikic
added a commit
to nikic/llvm-project
that referenced
this pull request
Feb 11, 2025
This library is provided by flang, not MLIR, so it should not be part of MLIR_LIBS. Fixes an issue introduced in llvm#120966. (cherry picked from commit ee76bda)
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
This library is provided by flang, not MLIR, so it should not be part of MLIR_LIBS. Fixes an issue introduced in llvm#120966.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is provided by flang, not MLIR, so it should not be part of MLIR_LIBS.
Fixes an issue introduced in #120966.